Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song not display on Discord #65

Closed
BlocBlocTheDev opened this issue Aug 10, 2024 · 19 comments
Closed

Song not display on Discord #65

BlocBlocTheDev opened this issue Aug 10, 2024 · 19 comments

Comments

@BlocBlocTheDev
Copy link

BlocBlocTheDev commented Aug 10, 2024

When we listen a music, discord don't display on the profile :

image

image

Same problem in "Playing" mod and "Listening" mod

Sorry for english, i'm a French guy... :/

@JustYuuto
Copy link
Owner

Je suis français aussi :)

Essaye avec ça : https://github.com/JustYuuto/deezer-discord-rpc/wiki/Troubleshooting

@BlocBlocTheDev
Copy link
Author

Re !

Malheureusement le problème persiste, même après avoir tenter de suivre les consigne de débugage...

Et quelque soit le mode utilisé rien n'apparait.

Le problème est apparu de mon coté après la dernière mise à jour (1.2.7)

J'ai tenté d'utiliser le RPC avec une autre application et ça marche donc il doit y avoir un souci avec la dernière MAJ :/

J'ai essayé de fournir le plus de détails possible en espérant que cela puisse aider !

@BlocBlocTheDev
Copy link
Author

EDIT : Même en revenant sur la version précédente le problème est toujours présent.

@JustYuuto
Copy link
Owner

Ah sorry je vais voir ça quand j'ai le temps et puis je ferais une update, merci du retour en tous cas

@BlocBlocTheDev
Copy link
Author

Pas de souci !

Ma piste c'est que Discord à changé un truc qui fait que l'application n'arrive plus à update le RPC.
Mais bon vu que je connais rien à JS ou Discord je préfère pas trop m'avancer dessus.

Bon courage !

@JuSteFat
Copy link

La même, je pense que ça vient aussi de discord pour que ça arrête de marcher comme ça du jour au lendemain

@flomirtech
Copy link

Bonjour, je confirme également le problème sur la version actuelle et la précédente. Discord a dû changer une fonction lié au RPC avec Deezer 😅

@TanukiPenny
Copy link
Contributor

Sorry to come in with English here lol, but I think Deezer changed something about their website that caused some of the mods that this program does to fail and break. That's why old versions do not work either cause they use the same website from Deezer. I just submitted PR #66 that should fix this!

@JuSteFat
Copy link

Sorry to come in with English here lol, but I think Deezer changed something about their website that caused some of the mods that this program does to fail and break. That's why old versions do not work either cause they use the same website from Deezer. I just submitted PR #66 that should fix this!

Can we test it ourselves by compiling the code?

@TanukiPenny
Copy link
Contributor

Yes, if you pull my fork and build it you can test it

@flomirtech
Copy link

Yes, if you pull my fork and build it you can test it

How do you transform your fork into an .exe file ?

@JuSteFat
Copy link

Yes, if you pull my fork and build it you can test it

2024-08-18 20_05_19-Window
Work guys gg you can use the pull

@JuSteFat
Copy link

JuSteFat commented Aug 18, 2024

Yes, if you pull my fork and build it you can test it

How do you transform your fork into an .exe file ?

I've managed to compile the application incorporating the pull request modifications. Here's an overview of the process:

  1. I applied the pull request changes manually in my local repository clone.

  2. I had to make several additional adjustments, notably in the package.json file and potentially in other configuration files.

  3. Next, I followed a compilation process similar to this one:

    • Installation of dependencies: npm install
    • TypeScript compilation: npm run build:ts
    • Executable creation: npm run build:electron
  4. The final executable is located in the dist folder.

It's important to note that the process required a few specific adaptations, not all of which are detailed here. If you'd like to reproduce exactly what I've done, I can provide more detailed instructions on the modifications made.

@TanukiPenny
Copy link
Contributor

TanukiPenny commented Aug 18, 2024

Pretty sure it's just 'yarn install' then 'yarn build'. Once the yarn build runs then the installer should be in a dist folder or a build folder. You should not have to modify anything except the changes I made in the pr

@JuSteFat
Copy link

Pretty sure it's just 'yarn install' then 'yarn build'. Once the yarn build runs then the installer should be in a dist folder or a build folder. You should not have to modify anything except the changes I made in the pr

Yes, but as I'd never compiled before, I followed claude-3.5's advice to use electron and make a portable version of deezer RPC. By the time it worked, I was happy.

@BlocBlocTheDev
Copy link
Author

GG guys, now wait for a release in this repo :)
🍾🍾🍾

@JuSteFat
Copy link

JuSteFat commented Aug 21, 2024

GG guys, now wait for a release in this repo :) 🍾🍾🍾

I just make a fork with the pull if you want (using yarn install) : https://github.com/JuSteFat/deezer-discord-rpc/releases/tag/deezer

@flomirtech
Copy link

image
Good Job @TanukiPenny & @JuSteFat.
It works perfercly !
Thanks you very much 🍾

@JustYuuto
Copy link
Owner

JustYuuto commented Aug 28, 2024

Hi there, sorry for my inactivity here :(

Thank you @TanukiPenny and @JuSteFat for your help 😅, anyway I released another version that fixes some things :)

I'll leave this issue open in case anyone has the issue even with the latest update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants