Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make plot and predict consistent #116

Closed
pat-alt opened this issue Aug 26, 2024 · 3 comments
Closed

Make plot and predict consistent #116

pat-alt opened this issue Aug 26, 2024 · 3 comments
Labels
enhancement New feature or request medium This is expected to be medium. question Further information is requested

Comments

@pat-alt
Copy link
Member

pat-alt commented Aug 26, 2024 •
edited
Loading

Should we return the observational noise when predicting from regression?

  • Currently, predict returns glm predictions for regression, not incorporating the observational noise (which I think I chose to do to stay consistent with PyTorch)
  • In TaijaPlotting.jl, we plot the interval that contains both sources of noise (parameters and observational).

In any case, we should add warnings and/or documentation

cc @pasq-cat
@pat-alt pat-alt added enhancement New feature or request question Further information is requested medium This is expected to be medium. labels Aug 26, 2024
@pat-alt pat-alt pinned this issue Aug 26, 2024
@pat-alt pat-alt mentioned this issue Aug 26, 2024
Open
@pasq-cat
Copy link
Member

pasq-cat commented Sep 1, 2024

image
directly from alex immer github docs.

@pasq-cat pasq-cat linked a pull request Sep 1, 2024 that will close this issue
added together the variances so that the results of predicts correspond to the posterior predictive distribution #117
Closed
@pat-alt
Copy link
Member Author

pat-alt commented Sep 2, 2024

image directly from alex immer github docs.

That's exactly the formula we use here for plotting. Let's discuss during our meeting.

pat-alt referenced this issue Sep 3, 2024
@pat-alt
Merge branch '116-make-plot-and-predict-consistent'
78c846e
@pat-alt
Copy link
Member Author

pat-alt commented Sep 3, 2024

addressed in #118

@pat-alt pat-alt closed this as completed Sep 3, 2024
@pat-alt pat-alt unpinned this issue Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request medium This is expected to be medium. question Further information is requested
Projects
None yet
Milestone
No milestone
3 participants
@pasq-cat @pat-alt and others