Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ^ with NaNMath.pow in nanmath-mode #671

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

devmotion
Copy link
Contributor

On the master branch:

julia> using Symbolics

julia> @variables x y;

julia> Base.remove_linenums!(build_function(x^y, [x, y]))
:(function (ˍ₋arg1,)
      begin
          (^)(ˍ₋arg1[1], ˍ₋arg1[2])
      end
  end)

With this PR:

julia> using Symbolics

julia> @variables x y;

julia> Base.remove_linenums!(build_function(x^y, [x, y]))
:(function (ˍ₋arg1,)
      begin
          (NaNMath.pow)(ˍ₋arg1[1], ˍ₋arg1[2])
      end
  end)

@devmotion
Copy link
Contributor Author

The Symbolics integration test failure seems harmless - apparently there's a test that compares an expression with a reference which includes ^, but with this PR the resulting expression uses (as desired) NaNMath.pow instead of ^.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant