Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back TermInterface #598

Merged
merged 7 commits into from
May 28, 2024
Merged

bring back TermInterface #598

merged 7 commits into from
May 28, 2024

Conversation

shashi
Copy link
Member

@shashi shashi commented May 17, 2024

No description provided.

Copy link
Contributor

github-actions bot commented May 17, 2024

Benchmark Results

master 9fba2e6... master/9fba2e6de2bc99...
overhead/acrule/a+2 0.732 ± 0.017 μs 0.743 ± 0.016 μs 0.986
overhead/acrule/a+2+b 0.714 ± 0.016 μs 0.727 ± 0.017 μs 0.982
overhead/acrule/a+b 0.261 ± 0.0086 μs 0.271 ± 0.0083 μs 0.965
overhead/acrule/noop:Int 25.9 ± 0.06 ns 24.7 ± 0.05 ns 1.05
overhead/acrule/noop:Sym 0.0361 ± 0.0052 μs 0.0367 ± 0.0058 μs 0.983
overhead/rule/noop:Int 0.0445 ± 0.00043 μs 0.0445 ± 0.00084 μs 1
overhead/rule/noop:Sym 0.0538 ± 0.0023 μs 0.0552 ± 0.0024 μs 0.975
overhead/rule/noop:Term 0.0548 ± 0.0025 μs 0.0558 ± 0.0027 μs 0.982
overhead/ruleset/noop:Int 0.129 ± 0.0033 μs 0.126 ± 0.0038 μs 1.03
overhead/ruleset/noop:Sym 0.146 ± 0.0039 μs 0.147 ± 0.0037 μs 0.991
overhead/ruleset/noop:Term 3.82 ± 0.14 μs 3.53 ± 0.13 μs 1.08
overhead/simplify/noop:Int 0.135 ± 0.001 μs 0.141 ± 0.001 μs 0.958
overhead/simplify/noop:Sym 0.149 ± 0.0022 μs 0.167 ± 0.0046 μs 0.895
overhead/simplify/noop:Term 0.0389 ± 0.0018 ms 0.0374 ± 0.0023 ms 1.04
overhead/simplify/randterm (+, *):serial 0.117 ± 0.0019 s 0.119 ± 0.0059 s 0.987
overhead/simplify/randterm (+, *):thread 0.0754 ± 0.025 s 0.0754 ± 0.024 s 1
overhead/simplify/randterm (/, *):serial 0.226 ± 0.006 ms 0.221 ± 0.0065 ms 1.02
overhead/simplify/randterm (/, *):thread 0.255 ± 0.0072 ms 0.25 ± 0.0071 ms 1.02
overhead/substitute/a 0.0615 ± 0.0014 ms 0.0584 ± 0.0017 ms 1.05
overhead/substitute/a,b 0.055 ± 0.0015 ms 0.0516 ± 0.0017 ms 1.07
overhead/substitute/a,b,c 17.8 ± 0.68 μs 16.5 ± 0.68 μs 1.08
polyform/easy_iszero 0.0346 ± 0.0018 ms 0.0321 ± 0.0017 ms 1.08
polyform/isone 2.79 ± 0.01 ns 4.02 ± 0.01 ns 0.693
polyform/iszero 1.85 ± 0.038 ms 1.76 ± 0.032 ms 1.06
polyform/simplify_fractions 2.51 ± 0.051 ms 2.4 ± 0.036 ms 1.05
time_to_load 4.57 ± 0.039 s 4.53 ± 0.02 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

src/types.jl Outdated
Comment on lines 538 to 540
function TermInterface.maketerm(::Type{<:BasicSymbolic}, head, args, type, metadata)
basicsymbolic(first(args), args[2:end], type, metadata)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let's use the new one directly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function TermInterface.maketerm(::Type{<:BasicSymbolic}, op, args, type=nothing, metadata=nothing)
    basicsymbolic(op, args, type, metadata)
end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project.toml Outdated
@@ -1,7 +1,7 @@
name = "SymbolicUtils"
uuid = "d1185830-fcd6-423d-90d6-eec64667417b"
authors = ["Shashi Gowda"]
version = "1.7.0"
version = "1.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 2.0?

@shashi shashi merged commit 9e3b9de into master May 28, 2024
11 of 12 checks passed
@shashi shashi deleted the s/revert-dep-revert branch May 28, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants