-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring back TermInterface #598
Conversation
…nterface-new"" This reverts commit 0b75a32.
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
src/types.jl
Outdated
function TermInterface.maketerm(::Type{<:BasicSymbolic}, head, args, type, metadata) | ||
basicsymbolic(first(args), args[2:end], type, metadata) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let's use the new one directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function TermInterface.maketerm(::Type{<:BasicSymbolic}, op, args, type=nothing, metadata=nothing)
basicsymbolic(op, args, type, metadata)
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project.toml
Outdated
@@ -1,7 +1,7 @@ | |||
name = "SymbolicUtils" | |||
uuid = "d1185830-fcd6-423d-90d6-eec64667417b" | |||
authors = ["Shashi Gowda"] | |||
version = "1.7.0" | |||
version = "1.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 2.0?
No description provided.