Enhancement: Include metadata in BasicSymbolic isequal comparison
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenszhu
force-pushed
the
isequal-with-metadata
branch
from
51efeed
to
1bce8ae
Compare
|
Following up on @AayushSabharwal's point from the Oct 31 meeting: including metadata in |
|
Adding metadata equality to h = hash2(sym)
cached = get(wvd, h, nothing)
if cached === nothing
wvd[h] = sym
elseif isequal2(cached, sym)
return cached
else
return sym
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isequalforBasicSymbolicshould consider metadata #665This pull request enhances the
isequalfunction forBasicSymbolicto incorporate metadata in the comparison. Previously, metadata was ignored when checking for equality between two symbolic objects. This could lead to incorrect results when mathematically equivalent sysmbolic objects have different metadata, especially for #658.This change ensures that two
BasicSymbolicobjects are considered equal only if they have the same expression type, the same symtypes, and identical metadata. This PR specifically supports the work done in #658 for internally handling hash collision.