Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclear std error for Kaplan Meier estimator #22

Open
tbeason opened this issue Jul 26, 2020 · 1 comment
Open

unclear std error for Kaplan Meier estimator #22

tbeason opened this issue Jul 26, 2020 · 1 comment

Comments

@tbeason
Copy link
Contributor

tbeason commented Jul 26, 2020

The standard error for the Kaplan-Meier estimator returns what I would consider to be only "half" of the correct value. Perhaps this is just a misunderstanding on my part, but I think it should return the square root of the variance of the survival function. Right now, it does not. To actually make it the standard error of the survival curve, you need to multiply the two (AKA km.survival .* km.stderr).

Should I make a PR to fix this, or was it intentional?

@ararslan
Copy link
Member

Currently it computes the pointwise standard error of the log of the survivor function using Greenwood's formula. I forget why exactly I opted for that but likely it was because that's also what R does (which is what this implementation tests against).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants