Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw when reaching maxiter #578

Open
andreasnoack opened this issue Nov 21, 2024 · 0 comments
Open

Don't throw when reaching maxiter #578

andreasnoack opened this issue Nov 21, 2024 · 0 comments
Labels
Milestone

Comments

@andreasnoack
Copy link
Member

I'm wondering if we shouldn't throw an exception when reaching the maximum number of iterations, but instead just terminate with a warning an possibly set some internal flag to signal that the termination is because of a failed line search. This would happen in a logistic regression with perfect separation so this is related to #9. Inference isn't valid in this case but the fit should work just fine for prediction.

@andreasnoack andreasnoack added this to the Release 2.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant