Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadratization under maximization #6

Open
pedromxavier opened this issue Nov 7, 2023 · 2 comments
Open

Quadratization under maximization #6

pedromxavier opened this issue Nov 7, 2023 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@pedromxavier
Copy link
Member

Currently, PBO assumes the minimization sense throughout its methods.
This has a special impact in the quadratization where different methods are selected according the each term's sign.
As pointed out in JuliaQUBO/ToQUBO.jl#77, this gets in the way of efficient, in-place quadratization.
A solution would be to add an optional flag or sign (-1, 1) parameter to multiply and divide each term`s coefficient before and after quadratization, respectively.

Any input, @bernalde @pedroripper?

@pedromxavier pedromxavier added the help wanted Extra attention is needed label Nov 7, 2023
@pedromxavier pedromxavier self-assigned this Nov 7, 2023
@bernalde
Copy link

bernalde commented Nov 7, 2023

I support the use of the optional flag parameter (we use it in other projects as well). Just make sure to keep the "books" for the sign inversion. Tests will be required.

@pedroripper
Copy link
Member

The optional flag sounds good to me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants