Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook preview for PRs #6

Open
greimel opened this issue Oct 14, 2021 · 1 comment · May be fixed by #8
Open

Notebook preview for PRs #6

greimel opened this issue Oct 14, 2021 · 1 comment · May be fixed by #8
Labels
enhancement New feature or request

Comments

@greimel
Copy link
Contributor

greimel commented Oct 14, 2021 •
edited
Loading

It would be really cool, if notebooks were also built for PRs. Though rather than uploading them to gh-pages it would be nice to just upload them as artifacts for a preview (e.g. using actions/upload-artifact@v2.)

I couldn't figure out how to do this in one action, so that gh-pages and the artifact preview share the cache correctly.
@fonsp fonsp added the enhancement New feature or request label Nov 23, 2021
@sosiristseng
Copy link
Member

Working on this, I found workflow-artifact-pull-request-comment helpful to leave a link to the artifacts in the comments.

As to cache sharing, the PR branch could read the base/default branch's cache but not the other way around, AFAIK.

@sosiristseng sosiristseng linked a pull request Dec 16, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feat] PR with artifact preview
3 participants
@greimel @fonsp @sosiristseng