Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on 1.11.0-rc #52

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Test on 1.11.0-rc #52

merged 2 commits into from
Sep 18, 2024

Conversation

greimel
Copy link
Collaborator

@greimel greimel commented Sep 18, 2024

you can now run test on the latest pre-release without specifying an explicit version

test on 1.11.0-rc
@@ -25,18 +25,18 @@ jobs:
# Without setting this, a failing test cancels all others
fail-fast: false
matrix:
julia-version: ["1.6", "1", "~1.10.0-0"]
julia-version: ["1.6", "1", "pre"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can test on ["lts", "1", "pre"], unless we plan on being backwards compatible with 1.6 for longer than required.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 1.6 because it was the LTS version. I like the idea of testing on the most recent LTS version.

@greimel
Copy link
Collaborator Author

greimel commented Sep 18, 2024

Done!

Bildschirmfoto 2024-09-18 um 13 04 48

(Despite being displayed as a member, I don't have write access. Please go ahead an merge)

@adrhill adrhill merged commit d7a1c5c into JuliaPluto:main Sep 18, 2024
3 checks passed
@greimel greimel deleted the patch-1 branch September 18, 2024 11:13
@eford
Copy link
Collaborator

eford commented Sep 18, 2024

(Despite being displayed as a member, I don't have write access. Please go ahead an merge)

I added you. I wasn't sure whether write or maintain was best. If someone else know, I'm happy to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants