adding invokelatest #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this also affects performance... Let's see if the performance tests pass! Otherwise it might be good to look into, and maybe the Distrubted source code can help |
|
Can you update from |
|
I also gave you write access to the repo |
I rebased 👍 |
|
impressive that all tests on older julia versions fail - is this normal? |
It should work if the call is replaced with |
Pangoraw
reviewed
Sep 5, 2024
Co-authored-by: Paul Berg <[email protected]>
Co-authored-by: Paul Berg <[email protected]>
Pangoraw
approved these changes
Sep 9, 2024
|
Thank you @Pangoraw, merging this then now |
|
@schlichtanders Can you make a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #83
this actually worked 👍
Not sure whether this should need an extra test. The lines are of course tested by the current tests already.