Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add backtrace information to RemoteException #66

Closed
schlichtanders opened this issue Nov 24, 2023 · 2 comments · Fixed by #67
Closed

Feature Request: Add backtrace information to RemoteException #66

schlichtanders opened this issue Nov 24, 2023 · 2 comments · Fixed by #67

Comments

@schlichtanders
Copy link
Collaborator

I am currently trying to figure out where this bug #65 comes from.

Unfortunately, Malt.jl misses to print stacktraces. Pluto has perfect support for stacktraces, but Malt misses them. It's a pity which will cause me at least a full working day of work...

Maybe you can copy the logic from Pluto.PlutoRunner.CapturedException?

@schlichtanders
Copy link
Collaborator Author

schlichtanders commented Nov 24, 2023

I found the location which needs to be changed:

err, false

Probably it is easiest to directly transform it to a string like it is done in a similar place

Malt.jl/src/worker.jl

Lines 126 to 128 in 34e6226

(false, sprint() do io
Base.invokelatest(showerror, io, e, catch_backtrace())
end)

Or altrnatively delete the sprint transformations early on and do it during construction of Malt.RemoteException (or even better as showerror implementation of Malt.RemoteException)

@Pangoraw
Copy link
Member

Or altrnatively delete the sprint transformations early on and do it during construction of Malt.RemoteException (or even better as showerror implementation of Malt.RemoteException)

The exception needs to be deserializable on the "main" process which is why we convert to string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants