Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed shell commands on Windows with 0.7 master #340

Closed
amellnik opened this issue Nov 29, 2017 · 3 comments
Closed

Malformed shell commands on Windows with 0.7 master #340

amellnik opened this issue Nov 29, 2017 · 3 comments

Comments

@amellnik
Copy link

This shows up when installing ZMQ (JuliaInterop/ZMQ.jl#159 (comment)), but I think this is a BinDeps issue. @BinDeps.install produces a malformed shell command (see the last argument) under 0.7 but not 0.6:

LoadError: failed process: Process(`'C:\Users\amellnik\AppData\Local\Julia-0.7.0-DEV\bin\7z.exe' x -y 
'C:\Users\amellnik\.julia\v0.7\WinRPM\cache\2\noarch%2Fmingw64-libwinpthread1-5.0.3-1.2.noarch.cpio' 
'-oC:\Users\amellnik\.julia\v0.7\WinRPM\deps'`, ProcessExited(2)) [2]
in expression starting at C:\Users\amellnik\.julia\v0.7\ZMQ\deps\build.jl:36
ararslan added a commit that referenced this issue Dec 6, 2017
@ararslan
Copy link
Member

ararslan commented Dec 6, 2017

So this wasn't happening on 0.6? It looks to me like it gets parsed the same way:

julia> `7z.exe x C:\\somefile.txt -y -oC:\\dir`
`7z.exe x 'C:\somefile.txt' -y '-oC:\dir'`

(Note the quotes around the entire output directory specification)

ararslan added a commit that referenced this issue Dec 7, 2017
ararslan added a commit that referenced this issue Dec 8, 2017
ararslan added a commit that referenced this issue Dec 8, 2017
@tkelman
Copy link
Contributor

tkelman commented Dec 8, 2017

There's nothing wrong with the command here at all. Windows can't replace in-use dlls. Close all julia executables, jupyter notebooks, etc and reboot for good measure, then try again without any changes to bindeps.

@amellnik
Copy link
Author

The issue I was seeing appears to be related to unusual characters (like +) in filenames and urls: JuliaPackaging/WinRPM.jl#134 (comment)

@amellnik amellnik closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants