Modify default_action to make function calls that use given mdp/pomdp #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 86.62% // Head: 85.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 86.62% 85.74% -0.89%
==========================================
Files 10 10
Lines 486 491 +5
==========================================
Hits 421 421
- Misses 65 70 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@zsunberg wondering if this is ready to be merged with the Master branch. Let me know. Thanks! |
zsunberg
requested changes
Feb 26, 2024
There was a problem hiding this comment.
A few changes, as we discussed:
- switch order so that the preferred version is in the try
- be more specific on what error you respond to. It should only respond to MethodErrors with the correct function inside. Otherwise it should rethrow
- Use Base.depwarn
- We'll need to tag a new minor version.
Thanks!
himanshugupta1009
force-pushed
the
master
branch
from
79d4944 to
c78b3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.