Upgrade Documenter to version 1.0 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Jul 6, 2024
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
devmotion
reviewed
Jul 10, 2024
test/Project.toml
Outdated
| @@ -4,5 +4,5 @@ Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f" | |||
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | |||
|
|
|||
| [compat] | |||
| Documenter = "0.27" | |||
| Documenter = "1" | |||
There was a problem hiding this comment.
It seems Julia 1.0 is not compatible with Documenter >= 1.0. It would be fine to drop support for Julia 1.0 at this point but I think we can keep it for now since it should not require any additional maintenance: For the doctests, docs/make.jl and the Documenter 1.0 specific settings are irrelevant, so keeping support for Documenter 0.27 in the tests seems safe.
Suggested change
| Documenter = "1" | |
| Documenter = "0.27, 1" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 3 3
Lines 32 32
=======================================
Hits 28 28
Misses 4 4 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 9870591805Details
💛 - Coveralls |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.