Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade github actions #23

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

pnavaro
Copy link
Contributor

@pnavaro pnavaro commented Jul 5, 2024

It removes the message "The following actions uses Node.js version which is deprecated..."

upgrade codecov action to v4
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -61,7 +61,7 @@ jobs:
shell: julia --project=. --color=yes {0}
- uses: julia-actions/julia-runtest@v1
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v2
- uses: codecov/codecov-action@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 4 of the action requires a token, tokenless uploads are not supported anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a secret "CODECOV_TOKEN" to the repo and changed the workflow configuration.

.github/workflows/CI.yml Show resolved Hide resolved
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (a3c1d24) to head (49d94a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   86.20%   87.50%   +1.29%     
==========================================
  Files           3        3              
  Lines          29       32       +3     
==========================================
+ Hits           25       28       +3     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion
Copy link
Member

Thank you!

@devmotion devmotion merged commit 3892406 into JuliaOptimalTransport:main Jul 10, 2024
17 of 18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9870151096

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.333%

Totals Coverage Status
Change from base Build 9869988529: 0.0%
Covered Lines: 28
Relevant Lines: 30

💛 - Coveralls

@pnavaro pnavaro deleted the github-actions branch July 22, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants