Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add workaround for regression in 1.11 #175

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Oct 8, 2024

Good news: 1.11 doesn't really break anything in Accessors, not even any @inferred test :)

The only (surprisingly, still unresolved) issue affecting us is JuliaLang/julia#54664. There's already a PR #170 to work it around, but that one uses internals. I asked on slack today and got a recommendation to just load REPL – it works indeed!

@aplavin
Copy link
Member Author

aplavin commented Oct 8, 2024

have no idea about the "invalidations" CI test failing...

@aplavin
Copy link
Member Author

aplavin commented Oct 9, 2024

I think @ranocha added invalidations test in #73. Any ideas on what's going on with it and how to fix?

@jw3126
Copy link
Member

jw3126 commented Oct 10, 2024

My hope would be that it gets fixed upsteam, so I could live with merging and this test failing for a while. If it never gets fixed upsteam and no brave soul wants to look into it, we can remove the test.
The fancy tooling is here to serve us, not the other way round.

@jw3126
Copy link
Member

jw3126 commented Oct 10, 2024

you want to bump the patch version?

@ranocha
Copy link
Contributor

ranocha commented Oct 10, 2024

Yeah, it looks like it's an upstream error in JET.jl: https://github.com/JuliaObjects/Accessors.jl/actions/runs/11242478221/job/31256238698?pr=175#step:5:449
Did you report it there? From my point of view, going ahead with this PR even when the upstream error persists is fine.

@aplavin
Copy link
Member Author

aplavin commented Oct 11, 2024

Ok let's just ignore invalidations CI for now.

you want to bump the patch version?

Not sure, why? It's just a test fix, seems like no need to update the new version for every user when nothing changed in the package...

@jw3126 jw3126 merged commit aec7a97 into JuliaObjects:master Oct 11, 2024
9 of 10 checks passed
This was referenced Oct 16, 2024
@aplavin aplavin deleted the tests-11 branch November 28, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants