Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZlibCompressor seems not to respect compression level #152

Open
asinghvi17 opened this issue Aug 19, 2024 · 0 comments
Open

ZlibCompressor seems not to respect compression level #152

asinghvi17 opened this issue Aug 19, 2024 · 0 comments

Comments

@asinghvi17
Copy link
Member

Zarr.jl/src/Compressors.jl

Lines 139 to 147 in f436713

function zuncompress(a, ::ZlibCompressor, T)
result = transcode(CodecZlib.ZlibDecompressor,a)
_reinterpret(Base.nonmissingtype(T),result)
end
function zcompress(a, ::ZlibCompressor)
a_uint8 = _reinterpret(UInt8,a)[:]
transcode(CodecZlib.ZlibCompressor, a_uint8)
end

It looks like the clevel field in the compressor is not accessed, even in zcompress? Not sure if this is intentional or I am missing something.

@asinghvi17 asinghvi17 changed the title ZlibCompressor doesn't respect compression level ZlibCompressor seems not to respect compression level Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant