CompatHelper: bump compat for MRIReco to 0.8, (keep existing compat) #186
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@beorostica could you check why the CI for this not running automatically? |
|
After reading some discussions, it's not possible to trigger pull requests this way, refer to this and this. Summarizing, it is not allowed to trigger events from a task that uses the GITHUB_TOKEN, this is for avoiding to create recursive workflows. Apparently, there are some workarounds (shown in the previous links) but we need to investigate further in order to implement them, By the time being, the solution is to manually perform the merge action from 'compat' branches. |
…39-343-03805923423
|
I think the problem was simpler, the branch was out of date, when I pressed "update branch" it started running the CI. |
|
It is a good idea to be aware of the behavior when CompatHelper detects a new update. I cannot say it for sure, but I remember the CompatHelper task never triggers the tests even when it performs a pull request to the master. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 40 40
Lines 2163 2163
=======================================
Hits 1997 1997
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. |
beorostica
deleted the
compathelper/new_version/2023-10-21-00-33-39-343-03805923423
branch
This pull request changes the compat entry for the
MRIRecopackage from0.6, 0.7to0.6, 0.7, 0.8.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.