Support HTTP 1 #18
Merged
Support HTTP 1 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
========================================
+ Coverage 0.00% 5.00% +5.00%
========================================
Files 1 3 +2
Lines 38 40 +2
========================================
+ Hits 0 2 +2
Misses 38 38 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DilumAluthge
approved these changes
Aug 14, 2023
|
@DilumAluthge @andreasnoack Could you re-enable the CompatHelper action? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for HTTP 1. Or rather, it bumps the compat entry but requires someone familiar with HTTP to carefully check whether HTTP 1 is actually supported or something in the code base has to be checked. It seems that unfortunately there are no actual tests, so one must not rely on CI tests passing successfully.
This updated was missed by the CompatHelper action since it was disabled due to inactivity: https://github.com/JuliaHealth/EHRAuthentication.jl/actions/workflows/CompatHelper.yml