Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asan-emirsaleh
Copy link

Correct basal package path and name fixed.
Graphs.jl > LightGraphs.jl

Correct basal package path and name fixed.
Graphs.jl > LightGraphs.jl
@matbesancon
Copy link
Member

thanks for the PR, I'm not sure this is necessary given that LGExtras is more or less inactive (doesn't even have a Project.toml)

@matbesancon
Copy link
Member

thoughts @gdalle @simonschoelly ?

@gdalle
Copy link
Member

gdalle commented May 18, 2022

Yes, I recommend you use (and possibly contribute to) the new package GraphsExtras.jl instead of this older one

@asan-emirsaleh
Copy link
Author

Thank you. Ok.
But as I understood the LightGraphsExtras.jl is addition to LightGraphs.jl, not to Graphs.jl. Also there is a reference to LightGraphsExtras.jl in LightGraphs's page. So I decided to fix this inconsistency.

@asan-emirsaleh
Copy link
Author

I checked the concordance of this page's description, doc page and Readme.
Description: Additional functionality for LightGraphs.jl
doc page of LightGraphs.jl: [LightGraphsExtras.jl](https://github.com/JuliaGraphs/LightGraphsExtras.jl): extra functions for graph analysis
README: Extra functionality for [Graphs](https://github.com/JuliaGraphs/Graphs.jl).

The link to the doc in README is invalid:
Documentation for this module is available at [Read The Docs](http://lightgraphsextrasjl.readthedocs.io/en/latest/?badge=latest)

So I suggest:

  1. fix the link to the LightGraphs.jl
  2. add the notion about the LightGraphsExtras.jl be discontinued
  3. fix the doc page linked from the README

@gdalle
Copy link
Member

gdalle commented Jun 19, 2022

Sorry for the delay @asan-emirsaleh. I'm okay with the changes you propose, if you want to flesh out your PR I'll review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants