Add _sum for KernelSum{<:AbstractVector} and associated tests
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #547 +/- ##
=======================================
Coverage 90.88% 90.89%
=======================================
Files 52 52
Lines 1459 1460 +1
=======================================
+ Hits 1326 1327 +1
Misses 133 133 ☔ View full report in Codecov by Sentry. |
theogf
commented
Feb 7, 2024
devmotion
reviewed
Feb 7, 2024
| @@ -45,6 +45,7 @@ Base.length(k::KernelSum) = length(k.kernels) | |||
|
|
|||
| _sum(f, ks::Tuple, args...) = f(first(ks), args...) + _sum(f, Base.tail(ks), args...) | |||
| _sum(f, ks::Tuple{Tx}, args...) where {Tx} = f(only(ks), args...) | |||
| _sum(f, ks::AbstractVector, args...) = sum(k -> f(k, args...), ks) | |||
There was a problem hiding this comment.
Codecov says the line is not covered by tests?
There was a problem hiding this comment.
There was a problem hiding this comment.
Strange, the Github annotation was complaining about this line.
There was a problem hiding this comment.
I can still see it here: https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/pull/547/files
There was a problem hiding this comment.
But I trust the codecov webpage more, maybe the annotation is just outdated.
devmotion
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the
_suminterface for vectors, allowing to useVectorinKernelSum. This is to fix #497Proposed changes
Add a method for
_sumand add the same tests existing forKerrnelSum{<:Tuple}toKernelSum{<:AbstractVector}.What alternatives have you considered?
🤷
Breaking changes
none