-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zygote v0.6.56 breaks tests #355
Comments
Based on the stacktrace and the |
Yeah apparently matrices were not thought of: julia> using LinearAlgebra
julia> reverse(UpperTriangular(rand(3, 3)))
ERROR: ArgumentError: cannot set index in the lower triangular part (3, 2) of an UpperTriangular matrix to a nonzero value (0.5468753916792359)
Stacktrace:
[1] setindex!
@ ~/.julia/juliaup/julia-1.8.5+0.x64.linux.gnu/share/julia/stdlib/v1.8/LinearAlgebra/src/triangular.jl:233 [inlined]
[2] _setindex!
@ ./abstractarray.jl:1374 [inlined]
[3] setindex!
@ ./abstractarray.jl:1344 [inlined]
[4] _reverse!(A::UpperTriangular{Float64, Matrix{Float64}}, dims::Tuple{Int64, Int64})
@ Base ./arraymath.jl:89
[5] _reverse!
@ ./arraymath.jl:71 [inlined]
[6] reverse!(A::UpperTriangular{Float64, Matrix{Float64}}; dims::Function)
@ Base ./arraymath.jl:70
[7] _reverse(A::UpperTriangular{Float64, Matrix{Float64}}, dims::Function)
@ Base ./arraymath.jl:60
[8] #reverse#247
@ ./arraymath.jl:59 [inlined]
[9] reverse(A::UpperTriangular{Float64, Matrix{Float64}})
@ Base ./arraymath.jl:59
[10] top-level scope
@ REPL[2]:1 |
@simsurace could you please open an issue on Zygote about this, request that the changes be reverted, and a new patch release tagged? |
Will be fixed upstream by FluxML/Zygote.jl#1396 |
Should be fixed now? |
Fixed by Zygote 0.6.58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The newest Zygote release unfortunately seems to have broken AbstractGPs again:
The text was updated successfully, but these errors were encountered: