Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the scope of @set and @local #126

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

fredrikekre
Copy link
Contributor

This patch adds a clarification about the scope of the right hand sides of @set and @local right hand sides.

I had some code similar to

function f()
    x = foo()
    @tasks for i in 1:3
        @local y = bar(x)
        local x = baz()
    end
end

which looks like it wouldn't work because x in bar(x) would normally throw an UndefVarError.

This patch adds a clarification about the scope of the right hand sides
of `@set` and `@local` right hand sides.
@MasonProtter
Copy link
Member

Great catch, LGTM.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.01%. Comparing base (cba9127) to head (2c6c0ea).
Report is 126 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   90.24%   86.01%   -4.23%     
==========================================
  Files           3        7       +4     
  Lines          82      572     +490     
==========================================
+ Hits           74      492     +418     
- Misses          8       80      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carstenbauer carstenbauer merged commit a301d00 into JuliaFolds2:master Sep 27, 2024
9 of 10 checks passed
@fredrikekre fredrikekre deleted the fe/scope branch September 27, 2024 06:03
@carstenbauer carstenbauer added the documentation Improvements or additions to documentation label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Skip-Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants