Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreedyScheduler with ntasks and chunksize given errors #120

Closed
fredrikekre opened this issue Sep 24, 2024 · 3 comments
Closed

GreedyScheduler with ntasks and chunksize given errors #120

fredrikekre opened this issue Sep 24, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@fredrikekre
Copy link
Contributor

julia> GreedyScheduler(; ntasks = 4, chunksize = 10)
ERROR: ArgumentError: nchunks and chunksize are mutually exclusive and only one of them may be a positive integer
@carstenbauer
Copy link
Member

carstenbauer commented Sep 24, 2024

ntasks == nchunks but we should improve the message

@fredrikekre
Copy link
Contributor Author

ntasks == nchunks

Why this restriction? It looks like nchunks is just set erroneously here:

# only choose nchunks default if chunksize hasn't been specified
?

@carstenbauer
Copy link
Member

I'm sorry, my comment was wrong. We used to have nchunks for all schedulers in the past and there it was == ntasks because we spawn one task per chunk. For the greedy scheduler, this isn't the case, of course.

@carstenbauer carstenbauer added the bug Something isn't working label Sep 24, 2024
fredrikekre added a commit to fredrikekre/OhMyThreads.jl that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants