You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think the tests in https://github.com/JuliaDiff/SparseDiffTools.jl/blob/master/test/test_gpu_ad.jl verify correctness of the Jacobian, it's only about whether or not the code runs. Since #302 breaks GPU tests, it means the code path with the wrong indexing was taken by GPUs, so GPU Jacobians have probably been wrong all along.
The text was updated successfully, but these errors were encountered:
I don't think the tests in https://github.com/JuliaDiff/SparseDiffTools.jl/blob/master/test/test_gpu_ad.jl verify correctness of the Jacobian, it's only about whether or not the code runs. Since #302 breaks GPU tests, it means the code path with the wrong indexing was taken by GPUs, so GPU Jacobians have probably been wrong all along.
The text was updated successfully, but these errors were encountered: