Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Julia v1.10+ #731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dlfivefifty
Copy link
Contributor

I think with v1.0 it makes sense to drop the support for earlier versions of Julia before the LTS. The benefits are:

  1. We can drop StaticArrays as a dependency
  2. Makes it less restricted in terms of testing compatibility and adding features
  3. Removal of a small amount of special cases in the tests

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (c310fb5) to head (a9af1a1).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   89.57%   89.38%   -0.20%     
==========================================
  Files          11       11              
  Lines         969      970       +1     
==========================================
- Hits          868      867       -1     
- Misses        101      103       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion
Copy link
Member

We can drop StaticArrays as a dependency

StaticArrays is only a regular dependency on Julia < 1.9, on Julia >= 1.9 it is only a weak dependency.

@mcabbott
Copy link
Member

mcabbott commented Dec 8, 2024

Maybe it's ideal to do this at 1.1? Then in case anyone still wants 1.6, there will be a 1.0 release they can install. I wouldn't put much work into supporting 1.6 now, but delaying slightly is easy.

@dlfivefifty
Copy link
Contributor Author

I can’t imagine anyone cares either way. Any Julia v1.6 users can still use ForwardDiff v0.x, if they are happy with old versions of Julia they are surely happy with old versions of ForwardDiff

the only point is to maintain developer sanity. Why support old versions for fictional users that probably don’t exist? Who is on Julia v1,6 but is upset about being on ForwardDiff v0.8??? Literally no one!

So why not just drop support and we can all move on with our lives.

@mcabbott
Copy link
Member

mcabbott commented Dec 8, 2024

My fictitious user is someone trying to update bounds so that their CI works! Not creating tighter coupling than we have to seems polite, when it's really easy. Agree real end-use isn't the issue.

@dlfivefifty
Copy link
Contributor Author

Yes I agree that’s a serious problem. Often trying to use outdated code fails even with manifests because it can figure out the right versionszzz

But I think that’s a Julia Pkg problem…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants