Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of implicit imports and clarify extension imports #649

Merged
merged 25 commits into from
Dec 2, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Nov 30, 2024

Versions

  • Bump DI to v0.6.24
  • Bump DIT to v0.9.1

DI extensions

  • Make DiffResults an explicit dependency of the ForwardDiff and ReverseDiff extensions
  • Remove implicit imports
  • Prefix every DI object with DI

DIT source and extensions

  • Remove implicit imports

DI and DIT tests

  • Add / activate ExplicitImports tests

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 98.92086% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.52%. Comparing base (fd3dc14) to head (c603214).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ractorExt/DifferentiationInterfaceDiffractorExt.jl 0.00% 2 Missing ⚠️
...erentiationInterfaceTest/src/scenarios/scenario.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         111      111           
  Lines        5536     5536           
=======================================
  Hits         5399     5399           
  Misses        137      137           
Flag Coverage Δ
DI 98.65% <99.23%> (ø)
DIT 95.35% <93.75%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle added the skipci Don't run CI tests and docs label Dec 2, 2024
@gdalle gdalle marked this pull request as ready for review December 2, 2024 17:50
@gdalle gdalle merged commit d53f8ac into main Dec 2, 2024
6 checks passed
@gdalle gdalle deleted the gd/explicitimports branch December 2, 2024 17:50
@gdalle gdalle mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skipci Don't run CI tests and docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant