Fix type inference failure in norm on structural matrix #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 1.11 failures on CI.
Not sure its the best way,
but it basically boils down to
Julia 1.11 introduced a minor regression in inference of:
zero.(Diagonal(Float64[;])) .* 0.0)
This used to infer to
Diagonal{Float64}
now it infers toUnion(Diagonal{Float64}, Matrix{Float64})
Similar to others.
Not sure this is exactly the cleanest or best way but this does fix it.
We also could change it not to test this.
But small type inference failures do easily grow into big ones -- union splitting isn't a silver bullet.
I am not stepping up to primary maintainer duties,
I am just on leave and thought i would check something and I saw CI was broken.
hopefully someone can review this