Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Tag system + Version System #25

Merged
merged 7 commits into from
Mar 18, 2024
Merged

WIP: Tag system + Version System #25

merged 7 commits into from
Mar 18, 2024

Conversation

VarLad
Copy link
Collaborator

@VarLad VarLad commented Mar 6, 2024

This PR attempts to add tag system + versioning system to PerfChecker.

@VarLad VarLad marked this pull request as draft March 6, 2024 04:23
@VarLad
Copy link
Collaborator Author

VarLad commented Mar 14, 2024

Whats left:

  • Tracking head
  • Introduce a way for users to provide package name + versions upon which we resolve the version and run these tests. (Preferably via the same dict as the rest of stuff)
  • Create temporary environments for users that provide package names and versions.

@VarLad VarLad marked this pull request as ready for review March 16, 2024 00:10
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 58.33%. Comparing base (eb188fd) to head (07447d1).

Files Patch % Lines
src/versions.jl 0.00% 33 Missing ⚠️
src/PerfChecker.jl 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev      #25       +/-   ##
===========================================
- Coverage   88.88%   58.33%   -30.56%     
===========================================
  Files           5        6        +1     
  Lines          45       96       +51     
===========================================
+ Hits           40       56       +16     
- Misses          5       40       +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VarLad
Copy link
Collaborator Author

VarLad commented Mar 18, 2024

Todo:

  • Add an example which deals with testing multiple versions of the same package.
  • Deal with head. The only reason I haven't done it is because I feel like users can just easily provide it inside the extra_pkgs key in the config dictionary.

On the next episode PR:

  • Convert the entire "Config Result" into a (TOML?) file and the ability to parse results from a (TOML?) file.

@Azzaare
Copy link
Member

Azzaare commented Mar 18, 2024

Nightly issue is related to some Pkg changes. We probably should not try to fix it before any v11-alpha/beta is out anyway.

@VarLad VarLad merged commit 30ffa3d into dev Mar 18, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants