Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add LaplaceRedux.jl to the MLJ registry #571

Closed
pasq-cat opened this issue Aug 26, 2024 · 15 comments
Closed

Request to add LaplaceRedux.jl to the MLJ registry #571

pasq-cat opened this issue Aug 26, 2024 · 15 comments

Comments

@pasq-cat
Copy link

we at Taija would like to add LaplaceRedux.jl to the MLJ's model registry.
we have written an interface for MLJ laplaceredux.jl interface,

LaplaceRedux.jl allows to compute the approximated posterior predictive distribution of any model through the Laplace approximation (as explained inhttps://arxiv.org/abs/2106.14806) and grants the users the possibility to compute credible intervals with a low computational overhead.
the LaplaceRedux.jl package is part of the taija (Trustworthy Artificial Intelligence in Julia) effort (https://github.com/JuliaTrustworthyAI) effort.

@ablaom
Copy link
Member

ablaom commented Aug 30, 2024

This looks very interesting, thanks. Just back from leave so it may take a week or two before I can look at this properly.

Note to self: Uses some non-public API from MLJFlux.

@ablaom
Copy link
Member

ablaom commented Sep 1, 2024

cc @EssamWissam

@ablaom
Copy link
Member

ablaom commented Sep 2, 2024

In the meantime @pasq-cat you may want to upgrade your doc-string to make it MLJ compliant.

@pasq-cat
Copy link
Author

pasq-cat commented Nov 7, 2024

@ablaom
Copy link
Member

ablaom commented Nov 7, 2024

Thanks for this. I can hopefully take another look in the next two weeks. Thanks for your patience.

@ablaom
Copy link
Member

ablaom commented Nov 18, 2024

To do list for @ablaom:

  • Check level=4 integration tests pass
  • Check document strings are compliant
  • Doc-string issues raised below have been addressed
  • Add to the MLJModel registry
  • Add model descriptors for MLJ Model Browser and generate new MLJ docs
  • Add to MLJ integration tests

@ablaom
Copy link
Member

ablaom commented Nov 18, 2024

@pasq-cat According to the docs for the regressor:

  • X: any table of input features (eg, a DataFrame) whose columns
    each have one of the following element scitypes: Continuous,
    Count, or <:OrderedFactor; check column scitypes with schema(X)

However, the input_scitype makes no mention of Count. Is this a mistake in the docstring or the input_scitype declaration?

@ablaom
Copy link
Member

ablaom commented Nov 18, 2024

Can I suggest avoiding unicode subscript characters for hyper-parameter names, as in μ₀. So μ0 or mu0 are friendlier. Of course I realize this breaking, unless you provide both options, like this mu0 = 0.0, μ₀=mu0 (but do use mu0 in the documentation).

@ablaom
Copy link
Member

ablaom commented Dec 1, 2024

Okay, I think the issues are now sorted on master. Can you please tag a new patch release. Then I can go ahead with registration.

@pasq-cat
Copy link
Author

pasq-cat commented Dec 2, 2024

Okay, I think the issues are now sorted on master. Can you please tag a new patch release. Then I can go ahead with registration.

@pat-alt can you do it? I am working this week and I come home really late.

@pat-alt
Copy link

pat-alt commented Dec 3, 2024

Thanks @pasq-cat. I've fixed the remaining things in JuliaTrustworthyAI/LaplaceRedux.jl#135, merged the PR and published a new release: https://github.com/JuliaTrustworthyAI/LaplaceRedux.jl/releases/tag/v1.2.0

@ablaom hopefully this should do this trick? Thanks once again for all your help with this and do let us know if anything else needs to be addressed.

@ablaom
Copy link
Member

ablaom commented Dec 4, 2024

Thanks once again for all your help

Your welcome.

There's another model being registered soon, so there may be a small delay - it's less work to do both together.

@ablaom
Copy link
Member

ablaom commented Dec 15, 2024

Thanks for your patience. There is a hiccup at MLJModels with the new version of Julia - something to do with Statistics compats (Julia "bug"). It looks like it will be sorted shortly and then I'll go ahead with your model.

@ablaom
Copy link
Member

ablaom commented Dec 20, 2024

Closed as complete.

@ablaom ablaom closed this as completed Dec 20, 2024
@ablaom
Copy link
Member

ablaom commented Dec 20, 2024

Closed as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants