-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machine
abstract type?
#188
Comments
You raise a good question here. Currently we have a plot recipe for machines bound to I hadn't thought of adding an PlotRecipes.plot(mach::Machine) = plot(machine.fitresult) What do you think? |
That’s a good way to do it! I would be quite content with this. |
Quick addendum: I think it should instead be: @recipe function default_machine_plot(mach::Machine)
mach.fitresult
end which is the idiomatic way to do it https://docs.juliaplots.org/latest/RecipesBase/syntax/ and will automatically forward all plotting information. And it should be |
Hey all,
I want to create a default
plot
interface for a fitted regressor in SymbolicRegression.jl. However I'm not sure what type to write it for. Is there a good abstract type I can specialize to for creating plots?e.g.,
I would like to create a method for
One way is by creating an extension to
MLJBase
but I'm wondering if there's just an abstract type for, say,AbstractMachine{SRRegressor}
.Cheers,
Miles
The text was updated successfully, but these errors were encountered: