Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of MLJModelInterface #184

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix usage of MLJModelInterface #184

merged 1 commit into from
Dec 22, 2023

Conversation

davnn
Copy link
Contributor

@davnn davnn commented Dec 20, 2023

The current usage of MLJModelInterface in the affected functions requires a global MLJModelInterface to be available, e.g. only importing @mlj_model would fail when MLJModelInterface is not available.

Using $MLJModelInterface fixes the problem by referring to the local MLJModelInterface.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9736531) 89.26% compared to head (33c6f60) 89.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #184   +/-   ##
=======================================
  Coverage   89.26%   89.26%           
=======================================
  Files           8        8           
  Lines         382      382           
=======================================
  Hits          341      341           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davnn
Copy link
Contributor Author

davnn commented Dec 20, 2023

@ablaom OutlierDetectionInterface.jl depends on @mlj_model, but cannot guarantee that MLJModelInterface is always available globally. Disregarding the problem for OutlierDetection.jl, this probably represents a bug for all users not importing the entire package.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ablaom ablaom merged commit 4393ab5 into JuliaAI:dev Dec 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants