You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to a recent change in ScientificTypesBase,jl from version 2.0 to 3.0, the ScientifictypesBase.scitype method is now a two argument method. Packages depending on MLJModelInterface.jl previously depended on the previous one argument version defined in version 2.0 series of ScientifictypesBase package.
A workaround is needed to avoid making MLJModelInterface breaking for its's users. This involves
Defining a one argument scitype method in MLJModelInterface. Something in the lines of
scitype(X) =scitype(get_interface_mode(), X)
scitype(::LightInterface, X) =throw(ArgumentError("FullInterface is needed..."))
The corresponding FullInterface method would be implemented at MLJBase/src/Interface/data_utils.jl.
But implementing the second step also leads to method import clashes with ScientificTypes.scitype at MLJBase. For now a hack at MLJBase/src/MLJBase.jl fixes this issue, but going forward the scitype method shouldn't be exported. Hence users that want to use the scitype method would have to qualify it with the package name e.g. MLJModelinterface.scitype(X).
The text was updated successfully, but these errors were encountered:
Due to a recent change in
ScientificTypesBase,jl
from version 2.0 to 3.0, theScientifictypesBase.scitype
method is now a two argument method. Packages depending onMLJModelInterface.jl
previously depended on the previous one argument version defined in version 2.0 series ofScientifictypesBase
package.A workaround is needed to avoid making
MLJModelInterface
breaking for its's users. This involvesscitype
method in MLJModelInterface. Something in the lines ofThe corresponding
FullInterface
method would be implemented atMLJBase/src/Interface/data_utils.jl
.scitype
method atMLJModelInterface
(Needed as users expect that thescitype
method is exported. see MLJModelInterface no longer exportingscitype
#129 )But implementing the second step also leads to method import clashes with
ScientificTypes.scitype
at MLJBase. For now a hack at MLJBase/src/MLJBase.jl fixes this issue, but going forward thescitype
method shouldn't be exported. Hence users that want to use thescitype
method would have to qualify it with the package name e.g.MLJModelinterface.scitype(X)
.The text was updated successfully, but these errors were encountered: