Fix/4274 write nicer html emails #4274 #4410
Conversation
…Write_nicer_html_emails
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| </ModalHeader> | ||
| <ModalContent> | ||
| <ContentTitle>Hi {'{name}'},</ContentTitle> | ||
| <ContentBody>New proposal {'{proposal name}'} is created... there are 2 days left to vote...</ContentBody> |
There was a problem hiding this comment.
According to the issue #4274
you must create six variations of notifications. Please create the text of the contentbody and button as variables.
| setShowModal(true) | ||
| } | ||
| const openModal280 = () => { | ||
| setShowModal280(true) |
There was a problem hiding this comment.
this value must be defined as content variable, not state variable
There was a problem hiding this comment.
@AnttoLion I don't know if this PR is still in progress, but in case it is:
Using React to generate html emails looks like a bad idea. Remember that the emails are generated on the backend so there shouldn't be any changes in packages/ui/*. Also you can't run js in emails and even though React can be used for ssr it's really not the right tool when the frontend can't run React.
|
@thesan This is superseded by my PR, can be closed |
|
Done in #4511 |
No description provided.