-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktopsession check contradictory #221
Comments
The warning should be updated, the correct session name is |
Actually since we check desktopSession validity already, it wouldn't make sense to warn on default value I think. That's why I proposed to remove that warning completely. |
Unless we want to go all the way to update the check to include "gamescope-wayland", and set desktopSession default to "gamescope-wayland" instead of null? but in that pr it explicitly removed it from list. "lib.lists.remove "gamescope-wayland" So removing the second warning completely would probably be the easier option here. |
I don't want to lose the warning, because then people will get confused by the default behavior. |
yes, default behavior could confuse people. check #225 instead |
jovian.steam.desktopSession = "steam-wayland";
, I get an error runnningnix flake check
jovian.steam.desktopSession
, I still get a big warning contradictory:IMO, it's probably best to ask user set desktopSession to steam-wayland explicitly in the first case.
The text was updated successfully, but these errors were encountered: