Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktopsession check contradictory #221

Closed
sg-qwt opened this issue Nov 18, 2023 · 5 comments · Fixed by #225
Closed

desktopsession check contradictory #221

sg-qwt opened this issue Nov 18, 2023 · 5 comments · Fixed by #225

Comments

@sg-qwt
Copy link
Contributor

sg-qwt commented Nov 18, 2023

I use deck as console without desktop seesion
  1. If I put jovian.steam.desktopSession = "steam-wayland";, I get an error runnning nix flake check
       error: Desktop session 'steam-wayland' not found.
       Valid values for 'jovian.steam.desktopSession' are:

       If you don't want a desktop session to switch to, remove 'jovian.steam.desktopSession' from your config.
  1. If I following the above advice removing jovian.steam.desktopSession, I still get a big warning contradictory:
This means that using the Switch to Desktop function in Gaming Mode will
relaunch Gaming Mode.

Set jovian.steam.desktopSession to the name of a desktop session, or "steam-wayland"
to keep this behavior.

IMO, it's probably best to ask user set desktopSession to steam-wayland explicitly in the first case.

@K900
Copy link
Contributor

K900 commented Nov 18, 2023

The warning should be updated, the correct session name is gamescope-wayland.

@sg-qwt
Copy link
Contributor Author

sg-qwt commented Nov 18, 2023

The warning should be updated, the correct session name is gamescope-wayland.

Actually since we check desktopSession validity already, it wouldn't make sense to warn on default value I think. That's why I proposed to remove that warning completely.

@sg-qwt
Copy link
Contributor Author

sg-qwt commented Nov 18, 2023

Unless we want to go all the way to update the check to include "gamescope-wayland", and set desktopSession default to "gamescope-wayland" instead of null? but in that pr it explicitly removed it from list. "lib.lists.remove "gamescope-wayland"

So removing the second warning completely would probably be the easier option here.

@K900
Copy link
Contributor

K900 commented Nov 18, 2023

I don't want to lose the warning, because then people will get confused by the default behavior.

@sg-qwt
Copy link
Contributor Author

sg-qwt commented Nov 18, 2023

I don't want to lose the warning, because then people will get confused by the default behavior.

yes, default behavior could confuse people. check #225 instead

@K900 K900 closed this as completed in #225 Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants