Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the session types use displayManager.sessionData.sessionNames for validation #163

Closed
samueldr opened this issue Sep 12, 2023 · 1 comment
Closed

Make the session types use displayManager.sessionData.sessionNames for validation #163

samueldr opened this issue Sep 12, 2023 · 1 comment
Labels
1. type: bug Something isn't working 2. priority: 1. high 2. topic: system integration About our integration of Steam stuff within NixOS

Comments

@samueldr
Copy link
Member

samueldr commented Sep 12, 2023 •
edited
Loading

Right now there's a real issue where users are not aware of the actual session name to use, and end-up unable to select their sessions.

The type should follow the defaultSession type in Nixpkgs.

This would solve #149, mostly.
@samueldr samueldr added 1. type: bug Something isn't working 2. priority: 1. high 2. topic: system integration About our integration of Steam stuff within NixOS labels Sep 12, 2023
@imadnyc imadnyc mentioned this issue Nov 3, 2023
Merged
@pongo1231
Copy link
Contributor

Should be solved by #201, no?

@K900 K900 closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. type: bug Something isn't working 2. priority: 1. high 2. topic: system integration About our integration of Steam stuff within NixOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samueldr @K900 @pongo1231