Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isNewScreenshot to Comparison Results #8

Open
emilyrohrbough opened this issue Jul 6, 2020 · 1 comment
Open

Add isNewScreenshot to Comparison Results #8

emilyrohrbough opened this issue Jul 6, 2020 · 1 comment

Comments

@emilyrohrbough
Copy link

Re-logging this issue from zinserjan/wdio-visual-regression-service#83

Often times new screenshots are not generated locally and checked in. This is not caught because our Travis CI builds create new reference screenshots are generated with no indication in the comparison results. It would be helpful to check if for a isNewScreenshot result boolean to assert all screenshots have been properly generated.

The BaseCompare would need changed here

The LocaleCompare would need changes in these places:

  1. When new
  2. When exists here and here
@emilyrohrbough
Copy link
Author

For reference a PR has been submitted to wdio-visual-regression-service by @webOS101 for this feature: zinserjan/wdio-visual-regression-service#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant