Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New name chosen during game causes them to be in a new session #82

Open
zapplecat opened this issue Sep 5, 2016 · 2 comments
Open

New name chosen during game causes them to be in a new session #82

zapplecat opened this issue Sep 5, 2016 · 2 comments
Assignees
Labels

Comments

@zapplecat
Copy link
Collaborator

I believe User is bound to a game by username, and not some session ID. This allows a user to switch names while they're part of a game, and can start their own game (or whatever).

This might easily break games mid game (unless we write logic to account for it).

I think this issue can be solved if we simply disable the name text box if they're already in a game. Although it would be a nice enhancement if we can let them change their names before the game officially starts.

@zapplecat zapplecat added the bug label Sep 5, 2016
@zapplecat
Copy link
Collaborator Author

To dive into this a bit more, a game will get deleted if all the users leave. But I believe that the current logic will compensate for a player leaving (since we have a many player to one game model). This might not be such a big problem (if a problem at all).

@corez92 corez92 self-assigned this Sep 27, 2016
@zapplecat
Copy link
Collaborator Author

Maybe there should be a confirmation message before a person chooses new name while they're in a game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants