Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

[BUG] Empty value check #160

Open
Kaffiend opened this issue Nov 26, 2023 · 1 comment
Open

[BUG] Empty value check #160

Kaffiend opened this issue Nov 26, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Kaffiend
Copy link

Event for saving configuration should check for empty value before parsing or handle it correctly if it's intentionally empty.
Instead getting an error on the screen when clearing a field, last good value maintained until new valid value.

To Reproduce
Steps to reproduce the behavior:
Server alias field, backspace current value until empty to replace value causes error to show.
Seems harmless currently but can be misleading to users.

Expected behavior
No error or clear message for field if optional

@Kaffiend Kaffiend added the bug Something isn't working label Nov 26, 2023
@JensvandeWiel
Copy link
Owner

This is because it updates the config on every change, even when it is empty

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants