From cf4f2a5476381652d10dcbffd6f1c2864eb94106 Mon Sep 17 00:00:00 2001
From: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com>
Date: Mon, 14 Mar 2022 13:12:12 +0800
Subject: [PATCH] chore(poolpair.controller): allow `to` to be optional when
 history cannot be resolved (#848)

* poolpair.service.ts to check undefined for history so that to amount can fail with optional

* add composite swap transaction to poolpairs.test.ts
---
 .../__tests__/api/poolpairs.test.ts           | 70 ++++++++++++++++---
 src/module.api/poolpair.service.ts            |  9 +--
 2 files changed, 64 insertions(+), 15 deletions(-)

diff --git a/packages/whale-api-client/__tests__/api/poolpairs.test.ts b/packages/whale-api-client/__tests__/api/poolpairs.test.ts
index d5da08c53..2c6c6799c 100644
--- a/packages/whale-api-client/__tests__/api/poolpairs.test.ts
+++ b/packages/whale-api-client/__tests__/api/poolpairs.test.ts
@@ -367,6 +367,14 @@ describe('poolswap', () => {
       tokenTo: 'DUSD'
     })
 
+    await testing.rpc.poolpair.compositeSwap({
+      from: await testing.address('swap'),
+      tokenFrom: 'A',
+      amountFrom: 123,
+      to: await testing.address('swap'),
+      tokenTo: 'C'
+    })
+
     const height = await container.getBlockCount()
     await container.generate(1)
     await service.waitForIndexedHeight(height)
@@ -377,7 +385,22 @@ describe('poolswap', () => {
       {
         id: expect.any(String),
         txid: expect.stringMatching(/[0-f]{64}/),
-        txno: 1,
+        txno: expect.any(Number),
+        poolPairId: '9',
+        sort: expect.any(String),
+        fromAmount: '123.00000000',
+        fromTokenId: 1,
+        block: {
+          hash: expect.stringMatching(/[0-f]{64}/),
+          height: expect.any(Number),
+          time: expect.any(Number),
+          medianTime: expect.any(Number)
+        }
+      },
+      {
+        id: expect.any(String),
+        txid: expect.stringMatching(/[0-f]{64}/),
+        txno: expect.any(Number),
         poolPairId: '9',
         sort: expect.any(String),
         fromAmount: '50.00000000',
@@ -392,7 +415,7 @@ describe('poolswap', () => {
       {
         id: expect.any(String),
         txid: expect.stringMatching(/[0-f]{64}/),
-        txno: 3,
+        txno: expect.any(Number),
         poolPairId: '9',
         sort: expect.any(String),
         fromAmount: '25.00000000',
@@ -412,7 +435,32 @@ describe('poolswap', () => {
       {
         id: expect.any(String),
         txid: expect.stringMatching(/[0-f]{64}/),
-        txno: 1,
+        txno: expect.any(Number),
+        poolPairId: '9',
+        sort: expect.any(String),
+        fromAmount: '123.00000000',
+        fromTokenId: 1,
+        block: {
+          hash: expect.stringMatching(/[0-f]{64}/),
+          height: expect.any(Number),
+          time: expect.any(Number),
+          medianTime: expect.any(Number)
+        },
+        from: {
+          address: expect.any(String),
+          symbol: 'A',
+          amount: '123.00000000'
+        },
+        to: {
+          address: expect.any(String),
+          amount: '10.42667420',
+          symbol: 'C'
+        }
+      },
+      {
+        id: expect.any(String),
+        txid: expect.stringMatching(/[0-f]{64}/),
+        txno: expect.any(Number),
         poolPairId: '9',
         sort: expect.any(String),
         fromAmount: '50.00000000',
@@ -437,7 +485,7 @@ describe('poolswap', () => {
       {
         id: expect.any(String),
         txid: expect.stringMatching(/[0-f]{64}/),
-        txno: 3,
+        txno: expect.any(Number),
         poolPairId: '9',
         sort: expect.any(String),
         fromAmount: '25.00000000',
@@ -471,14 +519,14 @@ describe('poolswap', () => {
       tokenA: {
         id: expect.any(String),
         symbol: 'A',
-        reserve: '175',
+        reserve: '298',
         blockCommission: '0',
         displaySymbol: 'dA'
       },
       tokenB: {
         id: '0',
         symbol: 'DFI',
-        reserve: '114.2857143',
+        reserve: '67.11409397',
         blockCommission: '0',
         displaySymbol: 'DFI'
       },
@@ -490,13 +538,13 @@ describe('poolswap', () => {
       commission: '0',
       totalLiquidity: {
         token: '141.42135623',
-        usd: '529.6978124963500510109100852'
+        usd: '311.06415164247241009334543708'
       },
       tradeEnabled: true,
       ownerAddress: expect.any(String),
       priceRatio: {
-        ab: '1.53124999',
-        ba: '0.65306122'
+        ab: '4.44019999',
+        ba: '0.22521508'
       },
       rewardPct: '0',
       creation: {
@@ -504,8 +552,8 @@ describe('poolswap', () => {
         height: expect.any(Number)
       },
       volume: {
-        d30: 113.50667410636073,
-        h24: 113.50667410636073
+        d30: 103.34010406914354,
+        h24: 103.34010406914354
       }
     })
 
diff --git a/src/module.api/poolpair.service.ts b/src/module.api/poolpair.service.ts
index cfe3a1048..65f4ab9ef 100644
--- a/src/module.api/poolpair.service.ts
+++ b/src/module.api/poolpair.service.ts
@@ -235,9 +235,6 @@ export class PoolPairService {
     }
 
     const history = await this.getAccountHistory(toAddress, height, txno)
-    if (history === undefined) {
-      return undefined
-    }
 
     return {
       from: {
@@ -401,7 +398,11 @@ function findPoolSwapDfTx (vouts: TransactionVout[]): PoolSwapDfTx | undefined {
   }
 }
 
-function findPoolSwapFromTo (history: AccountHistory, from: boolean): PoolSwapFromToData | undefined {
+function findPoolSwapFromTo (history: AccountHistory | undefined, from: boolean): PoolSwapFromToData | undefined {
+  if (history?.amounts === undefined) {
+    return undefined
+  }
+
   for (const amount of history.amounts) {
     const [value, symbol] = amount.split('@')
     const isNegative = value.startsWith('-')