TypeError is more consistent with AnnAssign

JelleZijlstra · Sep 12, 2023 · cd999bf · cd999bf
1 parent c8d43ca
commit cd999bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Lib/test/test_compile.py b/Lib/test/test_compile.py
@@ -467,7 +467,7 @@ def test_compile_invalid_namedexpr(self):
             type_ignores=[],
         )
 
-        with self.assertRaisesRegex(ValueError, "NamedExpr target must be a Name"):
+        with self.assertRaisesRegex(TypeError, "NamedExpr target must be a Name"):
             compile(ast.fix_missing_locations(m), "<file>", "exec")
 
     def test_compile_ast(self):

diff --git a/Python/ast.c b/Python/ast.c
@@ -382,7 +382,7 @@ validate_expr(struct validator *state, expr_ty exp, expr_context_ty ctx)
         break;
     case NamedExpr_kind:
         if (exp->v.NamedExpr.target->kind != Name_kind) {
-            PyErr_SetString(PyExc_ValueError,
+            PyErr_SetString(PyExc_TypeError,
                             "NamedExpr target must be a Name");
             return 0;
         }