Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current git head of moksha unconditionally checks for pulse #80

Open
TommyD opened this issue May 30, 2018 · 2 comments
Open

Current git head of moksha unconditionally checks for pulse #80

TommyD opened this issue May 30, 2018 · 2 comments

Comments

@TommyD
Copy link

TommyD commented May 30, 2018

As far as i can see, pulseaudio is only used together with the mixer module. But the configure check for the pulseaudio libraries are not conditionally based on enabled mixer module.

So even if the mixer module is disabled and there is no need for pulseaudio, current git head of moksha requires pulseaudio to be installed. Please make this configure.ac check conditional based on the check, if mixer module is enabled or not.

@rbtylee
Copy link
Collaborator

rbtylee commented May 30, 2018

Yes you are right. I was aware of this. My goal right now has been to get Moksha 3.0 ready for the release of Bodhi 5.0. Testing configure.ac for all possible options to ensure they all work correctly is low priority at this moment, it is on my list of stuff to do eventually. Until then patches are accepted if they work , barring that, unless I can interest someone else on working on this it is going to have to wait.

Thanks for reporting the issue tho. It will ensure we don't neglect it.

@rbtylee
Copy link
Collaborator

rbtylee commented Jun 3, 2022

commit conditionally check for pulse in Mixer module addresses this issue. Sorry for the long delay but I have been messing with the configure.ac file for other reasons soon to be committed and went ahead and fixed this.

I am closing this issue. However, I have not tested this with pulse not installed so if it fails to work as anticipated please reopen this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants