Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Maps -> GeoJSON conversion #22

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Google Maps -> GeoJSON conversion #22

wants to merge 24 commits into from

Conversation

justincy
Copy link
Contributor

  • mounted functions in the google.maps.geojson namespace (google.maps.geojson.from() instead of new GeoJSON())
  • created google.maps.geojson.to()
  • removed duplicate points in GeoJSON polygons for closing rings when converting to GMaps overlays; fixes Just a suggestion: for GeoJson's linear rings in polygons, remove the last vertex #17
  • setup a test suite using QUnit which tests GeoJSON -> GMaps, GMaps -> GeoJSON, and GeoJSON -> GMaps -> GeoJSON
  • fixed a bug in code that detected ring direction

See #20 for an explanation of why google.maps.geojson.to() doesn't produce GeometryCollections.

This is a pretty significant change so I understand if you have any concerns about merging it.

Justin York and others added 24 commits December 26, 2013 20:15
Restructure
5cda1cc
@justincy
Change the interface
b3bc10a 
Instead of `new GeoJSON(geojson, options)` it's now
`google.maps.geojson.fromGeoJSON(geojson, options)`.
@justincy
Begin writing toGeoJSON function
c079528 
Convert google.maps.Marker to GeoJSON Point.
@justincy
Add conversion for Polylines and Polygons
b3501ca
@justincy
Convert arrays over overlays
ae0ab62
@justincy
Setup tests for GeoJSON -> Google Maps conversion
6537183 
Remove duplicate point from GeoJSON Polygon rings when converting from
GeoJSON -> Google Maps
@justincy
Google Maps -> GeoJSON to uses same data set
5e8b6e6
@justincy
Add roundtrip conversion tests
c642d45 
This tests GeoJSON -> Google Maps -> GeoJSON
@justincy
Update the readme
0877b40
@justincy
Update bower package files
2a4890f
@justincy
Change names to just from and to
6d1a670
@justincy
Validate polygon syntax
e06f4e3
@justincy
Simplify GeoJSON type when possible
69af728
@justincy
Fix interactive test page
31baf04
@justincy
Make code more modular in from.js
be4488d
Add build script
9832718
Add new line
d48ba68
@justincy
Fix ccw calculation; add test suite for from._ccw
ffd53b0
Generate new build
464d18b
@justincy
Fix sign bug; change ccw to cw
b231225
@justincy
I think I finally fixed it
fce9630
@justincy
Get rid of lame build process; stick with one file
66456cb
@justincy
Fix interactive test page
53bf46d
@justincy
Fix tests
e6d3b5b 
probably missed that due to the frenzy I was in when trying to fix the
ring direction bug
@doismellburning
Copy link

GMaps to GeoJSON? Yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Just a suggestion: for GeoJson's linear rings in polygons, remove the last vertex
2 participants
@justincy @doismellburning