Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of SQ entries, in a 1:1 relationship #131

Open
JackKelly opened this issue May 18, 2024 · 0 comments
Open

Keep track of SQ entries, in a 1:1 relationship #131

JackKelly opened this issue May 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JackKelly
Copy link
Owner

JackKelly commented May 18, 2024

Instead of keeping track of things like GetRanges in flight, maybe keep track of our own representation of SQEs.

Pros: Might simplify our code? e.g.

  • we won't need to split the uring user_data into an index and an opcode, because the index is all we need (the index will take us to an object which only represents a single SQE). So we could get rid of our UringUserData struct.
  • Our Operation code won't need a conditional for different opcodes.
  • We could, again, just keep track of things by passing a raw pointer through the io_uring user_data. So we could get rid of Tracker. But need to benchmark.

Need to think how this will work when we optimise byte ranges. Maybe optimise byte ranges before implementing this?

@JackKelly JackKelly converted this from a draft issue May 18, 2024
@JackKelly JackKelly added the enhancement New feature or request label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant