Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to remember user decision of inclusion or exclusion of cross-referenced entries when copying #12341

Open
HoussemNasri opened this issue Dec 29, 2024 · 14 comments
Assignees
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@HoussemNasri
Copy link
Member

HoussemNasri commented Dec 29, 2024

Depends on #12340

What?

As part of implementing the include/exclude cross-references option in (#12340) when copying entries, we need to give users the option to preserve their selection across sessions for handling cross-references during the copy-paste operation.

How?

Add a "Remember my decision" checkbox to the "Copy to" dialog. When checked, this option will apply the user’s current selection (whether to include or exclude cross-referenced entries) automatically in future copy operations, without displaying the dialog again.

Store user decision in JabRefGuiPreferences.

Definition of Done

  • Unit tests to verify that the user's preference for cross-references is remembered and applied correctly.
@HoussemNasri HoussemNasri added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Dec 29, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Dec 29, 2024
@yashpandey06
Copy link

@HoussemNasri ...that seems interesting can i work on this ?

@yashpandey06
Copy link

@HoussemNasri just a curious question ...are we planning to take a part in the upcoming GSOC session ?

@HoussemNasri
Copy link
Member Author

that seems interesting can i work on this ?

This is a task to implement a complete new feature, unfortunately the tasks are not independent, #12339 is the first task in the list. You can ask to be assigned there if the task looks interesting.

@HoussemNasri
Copy link
Member Author

just a curious question ...are we planning to take a part in the upcoming GSOC session ?

Who are we? 😅

@yashpandey06
Copy link

just a curious question ...are we planning to take a part in the upcoming GSOC session ?

Who are we? 😅

Apologies for the confusion...I mean the org/project

@HoussemNasri
Copy link
Member Author

We probably will, there is not yet any official information from Google, but we expect that we will need to finalize our ideas at the beginning of the year.

@priyanshu16095
Copy link

How can I assign this task to myself?

@priyanshu16095
Copy link

I am interested in working on this.

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Jan 3, 2025
@Siedlerchr Siedlerchr moved this from Free to take to Assigned in Good First Issues Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

⚠ Note that this issue will become unassigned if it isn't closed within 30 days.

🔧 A maintainer can also add the Pinned label to prevent it from being unassigned automatically.

Happy coding! 🚀

@priyanshu16095
Copy link

Image
Is the UI okay according to the requirements given in the issue?

@Siedlerchr
Copy link
Member

Yeah, UI wise looks good!

@priyanshu16095
Copy link

Do I also need to write tests for the Preference class? Other Preference classes do not have any tests written.

@Siedlerchr
Copy link
Member

Siedlerchr commented Jan 9, 2025

No, we focus on testing the important stuff, mostly the logic stuff. We do have some UI tests, but they are not easy.
However, probably you can also stuff like viewModels. They just expose their data through bindings.

Just open a draft PR. Makes it easier to comment on specific details

@priyanshu16095 priyanshu16095 mentioned this issue Jan 9, 2025
7 tasks
@priyanshu16095
Copy link

I have created a draft PR. Please review it and provide any suggestions.

@priyanshu16095 priyanshu16095 mentioned this issue Jan 16, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Status: Assigned
Development

No branches or pull requests

4 participants