Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI migration #5

Closed
davetapley opened this issue Sep 23, 2022 · 7 comments
Closed

CI migration #5

davetapley opened this issue Sep 23, 2022 · 7 comments

Comments

@davetapley
Copy link
Member

davetapley commented Sep 23, 2022

Appveyor

Inherited

https://github.com/JEFuller/Piexif/blob/3422fbe7a12c3ebcc90532d8e1f4e3be32ece80c/appveyor.yml

https://ci.appveyor.com/project/hMatoba/piexif/history

Last pass Nov 2020: https://ci.appveyor.com/project/hMatoba/piexif/builds/36156177

Migration

Moved to https://ci.appveyor.com/project/davetapley/piexif

Travis

Inherited

https://github.com/hMatoba/Piexif/blob/3422fbe7a12c3ebcc90532d8e1f4e3be32ece80c/.travis.yml

No history: https://app.travis-ci.com/github/hMatoba/Piexif/builds

Migration

Moved to https://app.travis-ci.com/github/JEFuller/Piexif

But:

We are unable to start your build at this time. You exceeded the number of users allowed for your plan. Please review your plan details and follow the steps to resolution.

awaiting response from Support [email protected]
awaiting OSS build credits from Support [email protected]

Able to trigger build but lots of failures

Coveralls

https://coveralls.io/github/hMatoba/Piexif

Last build Nov 2020: https://coveralls.io/builds/34747634

Triggered from:

Piexif/.travis.yml

Lines 22 to 23 in 3422fbe

after_success:
coveralls

Not not sure how when no Travis history 🤔

@hartwork
Copy link

hartwork commented Jan 8, 2023

Hi!

In reply to #1 (comment), I would like to summarize what I see in the existing CI files linked above:

  • CPython 2.7, 3.5, 3.7, 3.8, pypy3
  • Linux and Windows
  • Tests suite run
  • Coveralls upload

I suggest to:

  • First clarify what of that is still needed, no longer needed, or needed more and then
  • re-write that with GitHub Actions, because fast, free, potent, well-integrated, here to stay.

I'd like to add a personal vote for dropping Python 2.7 and 3.5 because of end-of-life.
What do you think, what are the requirements?

PS: Here's the low-level bits for a handmade coveralls integration: https://github.com/asyncee/django-easy-select2/blob/f261c5b75145ed5203c500fd5b2fef177ec91d47/tox.ini#L34-L45 (with tox around, but that can be ignored)

@davetapley
Copy link
Member Author

@hartwork sorry I missed this 😊

  • I concur that GitHub Actions rewrite is best. I'll abandon appveyor and Travis and work on that
  • I'll see if 2.7 and 3.5 still work, but yes I think it's appropriate to drop them if they cause trouble

@hartwork
Copy link

  • I concur that GitHub Actions rewrite is best. I'll abandon appveyor and Travis and work on that

@davetapley cool!

  • I'll see if 2.7 and 3.5 still work, but yes I think it's appropriate to drop them if they cause trouble

Not sure about trouble but surely cost, both CI and human: Everything before 3.7 is dead: https://endoflife.date/python

@djjudas21
Copy link
Collaborator

Hey @davetapley, how are you getting on with this?

@davetapley
Copy link
Member Author

@djjudas21 haven't even started, but I can make time to merge PRs!

@djjudas21
Copy link
Collaborator

I've had a crack at porting to GitHub Actions in #7

@davetapley
Copy link
Member Author

#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants