From a622d1750fdaf7a3cfadf4261b6b4361616a69e8 Mon Sep 17 00:00:00 2001
From: "Uwe L. Korn" <uwe.korn@quantco.com>
Date: Sun, 8 Dec 2019 16:48:21 +0100
Subject: [PATCH] Type eager module

---
 CHANGES.rst                      |  8 +++++
 kartothek/core/factory.py        |  8 +++--
 kartothek/io/eager.py            | 50 ++++++++++++++++----------------
 kartothek/io_components/utils.py |  4 +--
 4 files changed, 41 insertions(+), 29 deletions(-)

diff --git a/CHANGES.rst b/CHANGES.rst
index add5dfb5..d853116b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,6 +2,14 @@
 Changelog
 =========
 
+Version 3.6.1 (2019-12-XX)
+==========================
+
+Improvements
+^^^^^^^^^^^^
+
+- Add more explicit typing to :mod:`kartothek.io.eager`.
+
 Version 3.6.0 (2019-12-03)
 ==========================
 
diff --git a/kartothek/core/factory.py b/kartothek/core/factory.py
index df17e955..e3ffba93 100644
--- a/kartothek/core/factory.py
+++ b/kartothek/core/factory.py
@@ -1,14 +1,18 @@
 # -*- coding: utf-8 -*-
 
-
 import copy
+from typing import Optional
 
 from kartothek.core.dataset import DatasetMetadata, DatasetMetadataBase
 from kartothek.core.utils import _check_callable
 
 
 def _ensure_factory(
-    dataset_uuid, store, factory, load_dataset_metadata, load_schema=True
+    dataset_uuid: Optional[str],
+    store,
+    factory,
+    load_dataset_metadata: bool,
+    load_schema: bool = True,
 ):
     if store is None and dataset_uuid is None and factory is not None:
         return factory
diff --git a/kartothek/io/eager.py b/kartothek/io/eager.py
index 47b166cc..3b8bc43e 100644
--- a/kartothek/io/eager.py
+++ b/kartothek/io/eager.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 import warnings
 from functools import partial
-from typing import cast
+from typing import Any, Callable, Dict, List, Optional, Tuple, Union, cast
 
 import pandas as pd
 
@@ -10,9 +10,9 @@
     make_meta,
     store_schema_metadata,
 )
-from kartothek.core.dataset import DatasetMetadataBuilder
+from kartothek.core.dataset import DatasetMetadata, DatasetMetadataBuilder
 from kartothek.core.docs import default_docs
-from kartothek.core.factory import _ensure_factory
+from kartothek.core.factory import DatasetFactory, _ensure_factory
 from kartothek.core.naming import (
     DEFAULT_METADATA_STORAGE_FORMAT,
     DEFAULT_METADATA_VERSION,
@@ -81,19 +81,19 @@ def delete_dataset(dataset_uuid=None, store=None, factory=None):
 @default_docs
 @normalize_args
 def read_dataset_as_dataframes(
-    dataset_uuid=None,
+    dataset_uuid: Optional[str] = None,
     store=None,
-    tables=None,
-    columns=None,
-    concat_partitions_on_primary_index=False,
-    predicate_pushdown_to_io=True,
-    categoricals=None,
-    label_filter=None,
-    dates_as_object=False,
-    predicates=None,
-    factory=None,
-    dispatch_by=None,
-):
+    tables: Optional[List[str]] = None,
+    columns: Dict[str, List[str]] = None,
+    concat_partitions_on_primary_index: bool = False,
+    predicate_pushdown_to_io: bool = True,
+    categoricals: Dict[str, List[str]] = None,
+    label_filter: Callable = None,
+    dates_as_object: bool = False,
+    predicates: Optional[List[List[Tuple[str, str, Any]]]] = None,
+    factory: Optional[DatasetFactory] = None,
+    dispatch_by: Optional[List[str]] = None,
+) -> List[pd.DataFrame]:
     """
     Read a dataset as a list of dataframes.
 
@@ -660,21 +660,21 @@ def write_single_partition(
 @default_docs
 @normalize_args
 def update_dataset_from_dataframes(
-    df_list,
+    df_list: List[Union[pd.DataFrame, Dict[str, pd.DataFrame]]],
     store=None,
-    dataset_uuid=None,
+    dataset_uuid: Optional[str] = None,
     delete_scope=None,
     metadata=None,
     df_serializer=None,
-    metadata_merger=None,
-    central_partition_metadata=True,
+    metadata_merger: Callable = None,
+    central_partition_metadata: bool = True,
     default_metadata_version=DEFAULT_METADATA_VERSION,
-    partition_on=None,
-    load_dynamic_metadata=True,
-    sort_partitions_by=None,
-    secondary_indices=None,
-    factory=None,
-):
+    partition_on: Optional[List[str]] = None,
+    load_dynamic_metadata: bool = True,
+    sort_partitions_by: Optional[str] = None,
+    secondary_indices: List[str] = None,
+    factory: Optional[DatasetFactory] = None,
+) -> DatasetMetadata:
     """
     Update a kartothek dataset in store at once, using a list of dataframes.
 
diff --git a/kartothek/io_components/utils.py b/kartothek/io_components/utils.py
index 19654373..ed8b4f65 100644
--- a/kartothek/io_components/utils.py
+++ b/kartothek/io_components/utils.py
@@ -2,10 +2,10 @@
 This module is a collection of helper functions
 """
 
-
 import collections
 import inspect
 import logging
+from typing import Callable, Optional
 
 import decorator
 import pandas as pd
@@ -378,7 +378,7 @@ def __getstate__(self):
         raise TypeError("Serialization not allowed. Please use a proper store factory.")
 
 
-def _make_callable(obj):
+def _make_callable(obj) -> Optional[Callable]:
     """
     Converting a plain store to a simple callable is perfectly fine for
     eager/iter/etc backends. Must not be used if the store/factory is serialized.