-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build prebuilt addon libcurl with ca bundle #224
Comments
Using |
curl/curl#4679 might be what we need. |
curl now has this ability to load ca certs from memory of curl 7.77; it landed in curl/curl#6662. However, it requires support for blob options (#253). In order to move this closer to the goal I've opened a PR for supporting blob options (#300) but it doesn't add support for all of the new options, and the curl for windows repo would need to be updated too I assume. |
Hey @johnwchadwick, thanks a lot for these! I will try to get those reviewed (and merged) in the following days. |
This can be done by passing the option
--with-ca-bundle
. Doing that would make it much easier to use the library withhttps
sites, as the client would not be required to passCURLOPT_CAINFO
anymore.Node.js version >=
v12.3.0
exposes the certificates it was bundled with, we could use them at build time: https://nodejs.org/api/tls.html#tls_tls_rootcertificatesTo generate a file from the property, it as simple as doing this:
The text was updated successfully, but these errors were encountered: