Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarity on setting getfields #258

Closed
kublasean opened this issue Dec 17, 2017 · 2 comments
Closed

clarity on setting getfields #258

kublasean opened this issue Dec 17, 2017 · 2 comments

Comments

@kublasean
Copy link

It would be nice if you added somewhere in the documentation - perhaps I'm missing it - or as a comment next to setGetfield() that when passing links as arguments (ex. $getfield = '?url=[I am a link]') that the urls should NOT be decoded with urldecode() beforehand, because that is done in your code.

I just spent like an hour trying to figure out why

$getfield = '?url=https%3A%2F%2Ftwitter.com%2FInterior%2Fstatus%2F507185938620219395'

wasn't working as a get field, and that's because it should have been

$getfield = '?url=https://twitter.com/Interior/status/507185938620219395'.

@J7mbo
Copy link
Owner

J7mbo commented Aug 16, 2018

Hey! Thanks for your input - could you point to where in my code your first get field suggestion is and I can fix that doc? I can't seem to find it... Thanks! :)

@kublasean
Copy link
Author

Y'know after reviewing why I made this issue and actually looking at your examples it's pretty clear that I didn't need to decode the urls. I thought I needed to at the time because I was using this in tandem with some other api where I did have to decode them. So nevermind! Works great by the way, I used this on my bands website to automatically propagate tweets from our band account to our home page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants